search

tiny-pilot / tinypilot

Use your Raspberry Pi as a browser-based KVM.
https://tinypilotkvm.com
MIT License
3k stars 252 forks source link

Populate TC358743 EDID file without Ansible #1616

Closed mtlynch closed 1 year ago

mtlynch commented 1 year ago

Related #1598

In continuing our elimination of Ansible, this reimplements the logic to populate the TC358743 EDID file (at /home/ustreamer/edids/tc358743-edid.hex) without Ansible.

We preserve the existing behavior that if the user has overridden the desired EDID by specifying a different value for ustreamer_edid, then we use that value when we populate /home/ustreamer/edids/tc358743-edid.hex on the next install.

The output of our decode_edid step changes because we're using a different version of the Docker image which seems to pull down a different version of the decode-edid which uses slightly different output formatting, but the values are all the same.

I was originally bundling this with #1604, but that PR is pretty large since it eliminates Ansible entirely, so I'm pulling out a small piece here.

Peer testing

To test this bundle run:

curl \
  --silent \
  --show-error \
  --location \
  https://raw.githubusercontent.com/tiny-pilot/tinypilot/master/scripts/install-bundle | \
  sudo bash -s -- \
    https://output.circle-artifacts.com/output/job/4a10bf35-34f1-4924-8af3-52f3dea7217a/artifacts/0/bundler/dist/tinypilot-community-20230901T1402Z-1.9.0-77+4903bc6.tgz

Review on CodeApprove

mtlynch commented 1 year ago
Automated comment from CodeApprove ➜

⏳ @jdeanwallace please review this Pull Request