search

tiny-pilot / tinypilot

Use your Raspberry Pi as a browser-based KVM.
https://tinypilotkvm.com
MIT License
2.95k stars 245 forks source link

Remove “Cancel” button from loading state #1687

Closed jotaen4tinypilot closed 7 months ago

jotaen4tinypilot commented 7 months ago

In our style guide, we say that dialog loading states shouldn’t have close/cancel buttons.

The <change-hostname> dialog violated this rule, which this PR fixes.

https://github.com/tiny-pilot/tinypilot/assets/83721279/e8e7df38-4ef9-42d0-82c8-2018b93cf0f8

Tangentially related https://github.com/tiny-pilot/tinypilot/issues/1684.

~Currently blocked by https://github.com/tiny-pilot/tinypilot/issues/1686 (e2e tests failing).~

Review on CodeApprove

jotaen4tinypilot commented 7 months ago
Automated comment from CodeApprove ➜

⏳ @jdeanwallace please review this Pull Request