As discussed in https://github.com/tiny-pilot/tinypilot-pro/pull/1139, this PR consolidates the wording for “Cancel”/“Close”/“Back”/“OK” buttons across all our dialogs, to only use “Close” or “Back”. It also outlines the rules in the style guide.
In the style guide, I restructured some of the existing text, to accommodate the new rules in a clearer way.
The code for the demo overlays has become borderline complex. To me, it’s still okay-ish for now, but for the future we could consider to simplify the setup, and make it more straightforward / less interactive.
I didn’t change the id attributes or CSS class names of the affected button elements, so their wording might now diverge from the label: e.g., we have a button labelled Close, with a cancel-hostname-change id attribute. To me, the UI label and the internal technical name are conceptually different enough that it wouldn’t be worth the hassle to keep them aligned, and we already diverge in other places anyway (e.g., we have a button labelled Paste, with a confirm-btn id attribute; or a button labelled Apply, with a save-btn id attribute.)
If we’d feel that it’s worth to unify all button labels with their id attribute / CSS class name, I’d suggest to do that in a separate refactoring step, and for all buttons in one go.
Related https://github.com/tiny-pilot/tinypilot/issues/1684. Stacked onto https://github.com/tiny-pilot/tinypilot/pull/1687.
As discussed in https://github.com/tiny-pilot/tinypilot-pro/pull/1139, this PR consolidates the wording for “Cancel”/“Close”/“Back”/“OK” buttons across all our dialogs, to only use “Close” or “Back”. It also outlines the rules in the style guide.
id
attributes or CSS class names of the affected button elements, so their wording might now diverge from the label: e.g., we have a button labelledClose
, with acancel-hostname-change
id attribute. To me, the UI label and the internal technical name are conceptually different enough that it wouldn’t be worth the hassle to keep them aligned, and we already diverge in other places anyway (e.g., we have a button labelledPaste
, with aconfirm-btn
id attribute; or a button labelledApply
, with asave-btn
id attribute.)id
attribute / CSS class name, I’d suggest to do that in a separate refactoring step, and for all buttons in one go.https://github.com/tiny-pilot/tinypilot/assets/83721279/e426c8db-b449-4e5f-968c-1d1bbcc129eb
~Currently blocked by https://github.com/tiny-pilot/tinypilot/issues/1686 (e2e tests failing).~