tiny-pilot / tinypilot

Use your Raspberry Pi as a browser-based KVM.
https://tinypilotkvm.com
MIT License
2.95k stars 245 forks source link

Consolidate button wording in dialogs (“Close” / “Back”) #1688

Closed jotaen4tinypilot closed 7 months ago

jotaen4tinypilot commented 7 months ago

Related https://github.com/tiny-pilot/tinypilot/issues/1684. Stacked onto https://github.com/tiny-pilot/tinypilot/pull/1687.

As discussed in https://github.com/tiny-pilot/tinypilot-pro/pull/1139, this PR consolidates the wording for “Cancel”/“Close”/“Back”/“OK” buttons across all our dialogs, to only use “Close” or “Back”. It also outlines the rules in the style guide.

https://github.com/tiny-pilot/tinypilot/assets/83721279/e426c8db-b449-4e5f-968c-1d1bbcc129eb

~Currently blocked by https://github.com/tiny-pilot/tinypilot/issues/1686 (e2e tests failing).~

Review on CodeApprove

jotaen4tinypilot commented 7 months ago
Automated comment from CodeApprove ➜

⏳ @jdeanwallace please review this Pull Request