search

tiny-pilot / tinypilot

Use your Raspberry Pi as a browser-based KVM.
https://tinypilotkvm.com
MIT License
2.89k stars 244 forks source link

Move install-bundle script to dev-scripts directory #1745

Closed jdeanwallace closed 4 months ago

jdeanwallace commented 4 months ago

Related https://github.com/tiny-pilot/tinypilot-pro/issues/1214

Based on our efforts to mitigate privilege escalation, the scripts/install-bundle script was identified as being both tinypilot-writeable and requiring root privileges. This PR moves the script to the dev-scripts/ directory.

Review on CodeApprove

mtlynch commented 4 months ago

Can we move scripts/install-bundle to the dev-scripts/ directory? Our contributing docs already recommend us to download and execute the install-bundle script directly from GitHub instead of from the local device:

Yeah, that's fine. My rationale was that when I wanted to test on a device, I can memorize a path on the device like /opt/tinypilot-privileged/scripts/install-bundle, whereas I can't memorize the download URL for the script from Github. But I'm probably running this script less frequently than you and Jan, so I'm fine with whatever's convenient for you guys.