Add “check” prefix to all testing/linting/code-style dev scripts

jotaen4tinypilot commented 2 months ago

This PR introduces a consistent check- prefix for all dev scripts that are concerned with anything related to checking (i.e., testing, linting, code-style).

I consolidated check-bash+build-bash and lint-frontend+build-javascript into one script respectively. To me, that would make more sense than having too many fine-granular scripts. We do it the same way in the check-python script already.
I also renamed all CircleCI jobs to reflect the dev script names.
I renamed build to check-all, and, while on it, also added the missing invocations. The only script that I wouldn’t cover here is check-e2e, because it’s noticeably resource-heavy than all other scripts, and requires non-trivial prerequisites.

jotaen4tinypilot commented 2 months ago

@shalver-tp @mtlynch this PR will rename our CircleCI jobs from build_... to check_.... The build_javascript and build_python jobs are marked as required for merging a PR in our Github repository settings. Could we rename/reassign them, to reflect the new names? (check_javascript and check_python)

I don’t have access to our repository settings, but I think this is configured for this repo under the “Settings” tab, then “Branches”, and then in the “Branch protection rules” of the master branch.

We can wait, though, until this PR is approved. I just wanted to give a heads-up already.

shalver-tp commented 2 months ago

@jotaen4tinypilot Hi Jan, I want to make sure this is implemented how you desire.

I can grant you temporary elevated access to this repo so that you can adjust the setting. Does that work for you?

jotaen4tinypilot commented 2 months ago

For the records: Scott and I hopped on a quick call and changed the settings together via his account.

tiny-pilot / tinypilot

Add “check” prefix to all testing/linting/code-style dev scripts #1791