search

tiny-pilot / tinypilot

Use your Raspberry Pi as a browser-based KVM.
https://tinypilotkvm.com
MIT License
3.07k stars 259 forks source link

Fix About dialog e2e license link tests #1806

Closed db39 closed 5 months ago

db39 commented 5 months ago

Resolves #1751

This change fixes the license link tests that fail when running using HTTPS on a live device.

Instead of using fetch, the new test uses Playwright's page.goto to check for a 200 response from each license URL.

Review on CodeApprove

db39 commented 5 months ago

I'm not sure why, but using await Promise.all with page.goto didn't work. I didn't dig too deep into why, but I think it's to do with async calls. Instead I swapped to a for loop to synchronously perform the goto which works.

db39 commented 5 months ago
Automated comment from CodeApprove ➜

⏳ @jdeanwallace please review this Pull Request