tiny-pilot / tinypilot

Use your Raspberry Pi as a browser-based KVM.
https://tinypilotkvm.com
MIT License
3.02k stars 252 forks source link

WiFi dialog: add script for printing marker section contents #1811

Closed jotaen4tinypilot closed 2 months ago

jotaen4tinypilot commented 3 months ago

Related https://github.com/tiny-pilot/tinypilot/issues/131, part (b). Stacked on https://github.com/tiny-pilot/tinypilot/pull/1804.

I realized that we need to add another privileged script for reading files with marker sections, because we are unable to read those directly via the Python process in case those files are owned by the root user.

Usage is demonstrated in the subsequent backend PR; it’s basically …

/opt/tinypilot-privileged/scripts/print-marker-sections /path/to/file.txt

… where the entire invocation has to be unblocked in the sudoers file.

Review on CodeApprove

jotaen4tinypilot commented 3 months ago

CircleCI seems to be having some erratic issues related to git connectivity… I try running them again later.

jotaen4tinypilot commented 3 months ago
Automated comment from CodeApprove ➜

⏳ @jdeanwallace please review this Pull Request