tiny-pilot / tinypilot

Use your Raspberry Pi as a browser-based KVM.
https://tinypilotkvm.com
MIT License
3.07k stars 259 forks source link

Remove assignment of unused “href” attribute #1849

Closed jotaen4tinypilot closed 1 month ago

jotaen4tinypilot commented 1 month ago

While working on the user script frontend, I stumbled across a tiny refactoring opportunity in the cursor submenu: in contrast to any of our other link elements in the menu, the cursor menu items are assigned an href attribute set to #. We don’t need to do this, as href isn’t a mandatory attribute. The presence of href="#" causes the link URL to be shown in the lower right corner of the browser window, which is slightly distracting because the menu elements are not supposed to be links in the actual sense.

Screenshot 2024-10-04 at 13 06 53

This PR therefore removes the href attribute assignment, so that the browser doesn’t show a URL preview tooltip on hover.

Review on CodeApprove