improved routes render logic

tinybike / augur-ui-react-components

[DEPRECATED] React components for the Augur UI

9 stars 8 forks source link

improved routes render logic #140

Closed stephensprinkle-zz closed 7 years ago

coveralls commented 7 years ago

Coverage remained the same at 64.583% when pulling 44d489c4c7c2879496bee29dec858910034695dc on 1294-bug-performance into a27601403d554564456703777e17b462f01dc423 on master.

tinybike commented 7 years ago

@stephensprinkle the bottom half of the trade panel no longer displays for me when I build this PR:

screenshot - 11112016 - 03 38 23 am

stephensprinkle-zz commented 7 years ago

I have a suspicion as to what this issue is — I’ll give it a look right after this: https://app.clubhouse.io/augur/story/1298/scalar-share-denomination-not-updating-share-denominations

Tracking here: https://app.clubhouse.io/augur/story/1299/double-check-logged-prop

coveralls commented 7 years ago

Coverage increased (+0.2%) to 64.657% when pulling 30032f182b2eecacf78fc6a831b25ce35f2d7f72 on 1294-bug-performance into ac86158c83fad2561d8effd06f8c8106a21acf94 on master.

stephensprinkle-zz commented 7 years ago

Latest changes resolve this issue.

Basically the logged state was being set on init, but not updated on prop change.

coveralls commented 7 years ago

Coverage remained the same at 64.449% when pulling 2624e7afd055432806062b63c0a3176b8df2efe0 on 1294-bug-performance into ac86158c83fad2561d8effd06f8c8106a21acf94 on master.