search

tinybike / augur-ui-react-components

[DEPRECATED] React components for the Augur UI
9 stars 8 forks source link

Adds support for post fixed values (‘K’, ‘M’, etc.) + truncation of existing values w/ inclusion of post fixed values + zero case handling #144

Closed stephensprinkle-zz closed 7 years ago

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 65.073% when pulling 09545404c341df42c952b680be9c4139b0564eef on 1306-share-denomination into 9181acfa57697f7524c3db12eac7d742b0297223 on master.

tinybike commented 7 years ago

@stephensprinkle is this intended to add truncated values to the order book? I'm still getting the un-truncated numbers:

screenshot - 11142016 - 06 01 26 pm

tinybike commented 7 years ago

Hm, the truncation happens fine with millishares and microshares, but not with regular old shares...

tinybike commented 7 years ago

Going ahead and merging this -- please do add truncation support for Shares, though :)