Closed stephensprinkle-zz closed 7 years ago
Couple of new warnings that show up on the trade page:
components.jsx:1244 Warning: Failed prop type: Invalid prop `minLimitPrice` of type `string` supplied to `OutcomeTrade`, expected `number`.
in OutcomeTrade (created by MarketActive)
in MarketActive (created by MarketView)
in section (created by MarketView)
in MarketViewprintWarning @ components.jsx:1244warning @ components.jsx:1268checkReactTypeSpec @ components.jsx:27889validatePropTypes @ components.jsx:21792createElement @ components.jsx:21826render @ components.jsx:34910_renderValidatedComponentWithoutOwnerOrContext @ components.jsx:17527_renderValidatedComponent @ components.jsx:17553performInitialMount @ components.jsx:17095mountComponent @ components.jsx:16983mountComponent @ components.jsx:24522mountChildren @ components.jsx:23367_createInitialChildren @ components.jsx:18499mountComponent @ components.jsx:18324mountComponent @ components.jsx:24522performInitialMount @ components.jsx:17109mountComponent @ components.jsx:16983mountComponent @ components.jsx:24522_mountChildAtIndex @ components.jsx:23552_updateChildren @ components.jsx:23468updateChildren @ components.jsx:23428_updateDOMChildren @ components.jsx:18733updateComponent @ components.jsx:18562receiveComponent @ components.jsx:18518receiveComponent @ components.jsx:24604_updateRenderedComponent @ components.jsx:17479_performComponentUpdate @ components.jsx:17457updateComponent @ components.jsx:17376receiveComponent @ components.jsx:17276receiveComponent @ components.jsx:24604_updateRenderedComponent @ components.jsx:17479_performComponentUpdate @ components.jsx:17457updateComponent @ components.jsx:17376receiveComponent @ components.jsx:17276receiveComponent @ components.jsx:24604updateChildren @ components.jsx:15351_reconcilerUpdateChildren @ components.jsx:23338_updateChildren @ components.jsx:23440updateChildren @ components.jsx:23428_updateDOMChildren @ components.jsx:18733updateComponent @ components.jsx:18562receiveComponent @ components.jsx:18518receiveComponent @ components.jsx:24604updateChildren @ components.jsx:15351_reconcilerUpdateChildren @ components.jsx:23338_updateChildren @ components.jsx:23440updateChildren @ components.jsx:23428_updateDOMChildren @ components.jsx:18733updateComponent @ components.jsx:18562receiveComponent @ components.jsx:18518receiveComponent @ components.jsx:24604updateChildren @ components.jsx:15351_reconcilerUpdateChildren @ components.jsx:23338_updateChildren @ components.jsx:23440updateChildren @ components.jsx:23428_updateDOMChildren @ components.jsx:18733updateComponent @ components.jsx:18562receiveComponent @ components.jsx:18518receiveComponent @ components.jsx:24604updateChildren @ components.jsx:15351_reconcilerUpdateChildren @ components.jsx:23338_updateChildren @ components.jsx:23440updateChildren @ components.jsx:23428_updateDOMChildren @ components.jsx:18733updateComponent @ components.jsx:18562receiveComponent @ components.jsx:18518receiveComponent @ components.jsx:24604updateChildren @ components.jsx:15351_reconcilerUpdateChildren @ components.jsx:23338_updateChildren @ components.jsx:23440updateChildren @ components.jsx:23428_updateDOMChildren @ components.jsx:18733updateComponent @ components.jsx:18562receiveComponent @ components.jsx:18518receiveComponent @ components.jsx:24604_updateRenderedComponent @ components.jsx:17479_performComponentUpdate @ components.jsx:17457updateComponent @ components.jsx:17376receiveComponent @ components.jsx:17276receiveComponent @ components.jsx:24604_updateRenderedComponent @ components.jsx:17479_performComponentUpdate @ components.jsx:17457updateComponent @ components.jsx:17376receiveComponent @ components.jsx:17276receiveComponent @ components.jsx:24604performUpdateIfNecessary @ components.jsx:17288performUpdateIfNecessary @ components.jsx:24638runBatchedUpdates @ components.jsx:25339perform @ components.jsx:27569perform @ components.jsx:27569perform @ components.jsx:25278flushBatchedUpdates @ components.jsx:25361closeAll @ components.jsx:27635perform @ components.jsx:27582batchedUpdates @ components.jsx:21195batchedUpdates @ components.jsx:25286dispatchEvent @ components.jsx:22158
components.jsx:1244 Warning: Failed prop type: Invalid prop `maxLimitPrice` of type `string` supplied to `OutcomeTrade`, expected `number`.
in OutcomeTrade (created by MarketActive)
in MarketActive (created by MarketView)
in section (created by MarketView)
in MarketView
Account button nearly pushed off the navbar:
Also this warning shows up on transaction display (don't think this is new though, looks familiar):
components.jsx:1244 Warning: Failed prop type: Invalid prop `prefix` of type `boolean` supplied to `ValueDenomination`, expected `string`.
in ValueDenomination (created by Transaction)
in Transaction (created by Transactions)
in div (created by Transactions)
in article (created by Transactions)
in Transactions (created by TransactionsPage)
in div (created by TransactionsPage)
in section (created by TransactionsPage)
in TransactionsPage
in div (created by Routes)
in Routes (created by AppComponent)
in Hammer (created by AppComponent)
in div (created by AppComponent)
in div (created by AppComponent)
in div (created by AppComponent)
in div (created by AppComponent)
in main (created by AppComponent)
in AppComponent
Text on "Your Order" popup is too close to the sides, needs a bit of spacing:
Another comment re: the last screenshot -- IMO it'd look better to hide the scrollbars until they're needed.
Aside from minor issues mentioned above, looks good! Merging.
(Just created clubhouse issues for the above comments.)
This PR encompasses the changes from the following CH stories:
1162 1364 1370 1336 1310 1344