search

tinybike / augur-ui-react-components

[DEPRECATED] React components for the Augur UI
9 stars 8 forks source link

339 missing no #97

Closed stephensprinkle-zz closed 8 years ago

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.6%) to 61.804% when pulling 4f72b420a5eba96ce5c37fdfdb819e141130d256 on 339-missing-no into 48f4fe7b7b62e40c014b6176cd0cc3fe40e292a7 on master.

tinybike commented 8 years ago

One of the tests is failing:

  1) augur-ui-react-components market state market.outcomes:
     TypeError: Cannot read property 'forEach' of undefined
      at market.js:223:5
      at Array.forEach (native)
      at Context.<anonymous> (market.js:122:20)
stephensprinkle-zz commented 8 years ago

Interesting…I’d originally done a std push (linting/tests) — just did another check of the tests w/ all passing locally — pushed up a rebase against master…let’s see what happens :)

coveralls commented 8 years ago

Coverage Status

Coverage increased (+1.09%) to 62.069% when pulling d70a24e58bded7256c75e1c88f6ad966df6d2e21 on 339-missing-no into 817c234defecdb36b63718de96827d7e1153408d on master.

stephensprinkle-zz commented 8 years ago

Ah, looks to fail specifically when tested against node 6.5.0. This is actually related to when npm run coverage is executed. Digging in...

stephensprinkle-zz commented 8 years ago

Very odd that npm run coverage was failing but npm run test wasn’t — latest push should resolve.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+1.09%) to 62.069% when pulling a1c2b447e35a3ce1c91767e560d1e971fbe3214e on 339-missing-no into 817c234defecdb36b63718de96827d7e1153408d on master.

tinybike commented 8 years ago

https://github.com/AugurProject/augur/pull/763 is still failing for me when I try to run it in the browser -- should I hold off on merging this until that one is ready?

stephensprinkle-zz commented 8 years ago

Ok, I’m seeing the issue now — give me just a minute to resolve.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+1.1%) to 61.579% when pulling 89de6dd17e172191fc774e8f72744dd77004baec on 339-missing-no into 4608226b2055cd4764faaf6ac7c33c3fca5c7629 on master.