search

tinybirdco / ci

Collection of configuration files that enable CI flows for Tinybird projects
MIT License
2 stars 3 forks source link

Rename from Environment to Branch #50

Closed alexon1234 closed 5 months ago

alexon1234 commented 5 months ago

Description

Rename the term Environment to Branch

alrocar commented 5 months ago

Let's wait a bit to merge this because I have an ongoing PR and maybe I can include it there

xavijam commented 5 months ago

I'm redoing the CI/CD guide and I realized we should do this. Could we do it now?

xavijam commented 5 months ago

Could you take a look @alexon1234 to my last changes 🙏 ?

alexon1234 commented 5 months ago

Could you take a look @alexon1234 to my last changes 🙏 ?

Looks fine, but @alrocar wanted to merge some changes. So let's wait until he finish his changes

jlmadurga commented 5 months ago

Could you take a look @alexon1234 to my last changes 🙏 ?

Looks fine, but @alrocar wanted to merge some changes. So let's wait until he finish his changes

I think it was already merged

alexon1234 commented 5 months ago

BTW I can not approve my own PR cc/ @xavijam @jlmadurga