tinybirdco / web-analytics-starter-kit

Tinybird Web Analytics Starter Kit
https://tinybird.co/starter-kits/web-analytics
MIT License
350 stars 36 forks source link

Add Deploy to Vercel section with one click button #44

Closed sdairs closed 1 year ago

sdairs commented 1 year ago

Adds a section to the README that describes deploying the dashboard to Vercel with a one-click button

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
analytics-dashboard ✅ Ready (Inspect) Visit Preview Dec 13, 2022 at 10:08AM (UTC)
alejandromav commented 1 year ago

Thanks for this!

Looks good to me, I think it's a good idea. I just have a couple questions:

Thoughts? Thanks!

sdairs commented 1 year ago

@alejandromav

  1. I kept this seperate so as to not confuse the existing 1,2,3 flow, so it's obvious there is the hosted dashboard example + you can host your own
  2. Agreed
  3. It already only deploys the dashboard to Vercel using the 'root directory' parameter. Using the full Git URL means the user gets a full repo fork, which is desirable. Suffixing the URL with the tree only gets a partial clone.