tinybirdco / web-analytics-starter-kit

Tinybird Web Analytics Starter Kit
https://tinybird.co/starter-kits/web-analytics
MIT License
350 stars 36 forks source link

Add UTM params support #50

Closed dmytro-tinybird closed 1 year ago

dmytro-tinybird commented 1 year ago

Description

Dashboard

Tracker

Tinybird

Fixes #51

Type of change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
analytics-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 27, 2023 at 9:53AM (UTC)
sdairs commented 1 year ago

@davidnmargulies @gnzjgo this would be an interesting one to get your review on how UTM params have been added to the Tinybird project. We could also do with some feedback on how we should handle/document upgrades/migrations from Workspaces uses the old version to this new version

davidnmargulies commented 1 year ago

IMO we should not be doing upgrades to people's workspaces - we should communicate the changes, explain how to implement them, and let people do it themselves. This is a 'starter' kit after all, not a fully managed solution (although it would be nice to connect a workspace to a repo... not sure how that gels with 'iterating projects' but could be an interesting use case).

For this specific change, the one wrinkle of complexity is that it changes an MV. We have to include really detailed instructions for people to create a new MV without breaking their flow.

sdairs commented 1 year ago

@davidnmargulies completely agree - I wasn't suggesting we forcibly migrate everyone 😅! What I meant was, we should work out what the migration process looks like, and work out how we document & communicate that to people who want to upgrade - because, as you say, the MV change has some complexity

alejandromav commented 1 year ago

@davidnmargulies completely agree - I wasn't suggesting we forcibly migrate everyone 😅! What I meant was, we should work out what the migration process looks like, and work out how we document & communicate that to people who want to upgrade - because, as you say, the MV change has some complexity

What about showing a message with instructions to set up the required Tinybird resources (data sources, pipes, endpoints, MVs, etc.) within the dashboard new components?

Something like:

Hey! We've added a new feature to the Dashboard, please follow these instructions to enable it.

Maybe we could even add an "Upgrade" button in then Workspace home, where we already have the banner.