tinybirdco / web-analytics-starter-kit

Tinybird Web Analytics Starter Kit

https://tinybird.co/starter-kits/web-analytics

MIT License

341 stars 35 forks source link

Adding the possibility to set the domain for the cookie #64

Closed xavijam closed 1 year ago

xavijam commented 1 year ago

Description

Allow setting the domain for the cookie using data-domain in the script. The main use case is allowing to share the cookie in different subdomains.

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
analytics-dashboard	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 12, 2023 0:38am

alejandromav commented 1 year ago

Obviously not a lawyer, but this should be fine to the best of my understanding of the GDPR regulations.

https://www.cookiebot.com/en/gdpr-cookies/

We're using an anonimized cookie that only lasts for 30 minutes
No PII is tracked, processed or stored at any time

I can't find any reason for not sharing this session cookie across subdomains, as long as they're used for the same purpose (the starter kit use case) and owned/controlled by the same entity.