tinybirdco / web-analytics-starter-kit

Tinybird Web Analytics Starter Kit

https://tinybird.co/starter-kits/web-analytics

MIT License

350 stars 36 forks source link

[#90] Fix the session count in top_devices and top_browsers, using an… #91

Closed alejandromav closed 1 month ago

alejandromav commented 1 month ago

Description

Using analytics_sessions_mv instead of analytics_sources_mv in the top_devices and top_browsers endpoints.

Another positive side effect is that those endpoint will perform better at scale, given the cardinality of analytics_sessions_mv is lower.

Fixes #90

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation

How Has This Been Tested?

I was able to reproduce this issue:

[X] Test top_devices endpoint reports and accurate session count with the change
[X] Same for top_browsers

Checklist:

[X] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[X] I have update the CHANGELOG
[X] New and existing unit tests pass locally with my changes

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
analytics-dashboard	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 25, 2024 5:06pm