search

tinycreative / react-native-intercom

React Native wrapper for Intercom.io
MIT License
405 stars 279 forks source link

Configuration 'compile' is obsolete and has been replaced with 'implementation' and 'api' #229

Closed nerboda closed 5 years ago

nerboda commented 6 years ago

Need to replace 'compile' with 'implementation' in build.gradle file so gradle stops throwing build warning - http://d.android.com/r/tools/update-dependency-configurations.html

dani-mp commented 5 years ago

Hi, @nerboda. I'm not an Android expert, so I was wondering if the change is as easy as set implementation project(':react-native-intercom') instead of compile project(':react-native-intercom'). Is this correct? Thanks!

nerboda commented 5 years ago

@danielmartinprieto correct, you can see the change I made here https://github.com/tinycreative/react-native-intercom/pull/230/files