search

tinycreative / react-native-intercom

React Native wrapper for Intercom.io
MIT License
406 stars 280 forks source link

Updates Intercom SDK to version 6.0 #338

Closed mussegam closed 4 years ago

mussegam commented 4 years ago

After the deprecation notice from Intercom I have updated the project to use v6.0.0

soban1234 commented 4 years ago

how can i update v5.x.x to v6.x.x

stianjensen commented 4 years ago

how can i update v5.x.x to v6.x.x

If you need to bump immediately, before a new release of react-native-intercom is available, you can change your dependency in package.json to point to the commit from this PR directly:

"react-native-intercom": "git+https://github.com/mussegam/react-native-intercom.git#86a436510262bf2a4c83d2164dc40d057bf691ac"
soban1234 commented 4 years ago

After the deprecation notice from Intercom I have updated the project to use v6.0.0

@mussegam by changing build.gradle to implementation 'io.intercom.android:intercom-sdk-base:6.+' minSdkVersion safeExtGet("minSdkVersion", 21)

and react-native-intercom/podspec to s.platform = :ios, '10.0' s.dependency 'Intercom', '~> 6.0.0'

will that enough to upgrade to v6, or any thing else is there?

soban1234 commented 4 years ago

how can i update v5.x.x to v6.x.x

If you need to bump immediately, before a new release of react-native-intercom is available, you can change your dependency in package.json to point to the commit from this PR directly:

"react-native-intercom": "git+https://github.com/mussegam/react-native-intercom.git#86a436510262bf2a4c83d2164dc40d057bf691ac"

bundle of thanks for quick reply, is it possible if i directly update implementation 'io.intercom.android:intercom-sdk-base:6.+' minSdkVersion safeExtGet("minSdkVersion", 21)

and react-native-intercom/podspec to s.platform = :ios, '10.0' s.dependency 'Intercom', '~> 6.0.0'

in my existing code, if i updates these changes, would that be enough?

stianjensen commented 4 years ago

Intercom's migration guide to 6.0.0 is here: https://developers.intercom.com/installing-intercom/docs/migrating-to-v600

It looks like only iOS requires manual work if you use either push notifications or deep linking. Android version mentions no extra steps.

soban1234 commented 4 years ago

hey guys, any body please help, Notifications on android are not working when i updated it to this PR #338 it was working fine before this PR.

soban1234 commented 4 years ago

hey guys, any body please help, Notifications on android are not working when i updated it to this PR #338 it was working fine before this PR.

i updated this line in android/app build.gradle compile 'io.intercom.android:intercom-sdk-fcm:5.+' to compile 'io.intercom.android:intercom-sdk-fcm:6.+' it started to work.

soban1234 commented 4 years ago

when i upgrade to #338 this error is being occured while installing the pods\

[!] CocoaPods could not find compatible versions for pod "Intercom": In snapshot (Podfile.lock): Intercom (= 5.5.2, ~> 5.0)

In Podfile: react-native-intercom (from ../node_modules/react-native-intercom) was resolved to 13.0.1, which depends on Intercom (~> 6.0.0)

You have either:

soban1234 commented 4 years ago

when i upgrade to #338 this error is being occured while installing the pods\

[!] CocoaPods could not find compatible versions for pod "Intercom": In snapshot (Podfile.lock): Intercom (= 5.5.2, ~> 5.0)

In Podfile: react-native-intercom (from ../node_modules/react-native-intercom) was resolved to 13.0.1, which depends on Intercom (~> 6.0.0)

You have either:

  • out-of-date source repos which you can update with pod repo update or with pod install --repo-update.
  • changed the constraints of dependency Intercom inside your development pod react-native-intercom. You should run pod update Intercom to apply changes you've made.

in your podfile.lock

builtbyproxy commented 4 years ago

@browniefed @mptorz When you are free could you please add a new release with this version. I cannot find any info on what repurcussions this has for the rest of our code?

Do we need to change anything other than the package number?

sobanarshad85 commented 4 years ago

@builtbyproxy goto PR #338 it is just one or two or three minor changes. yeah if they send an update for these changes that would be great. otherwise you go to 338 and change your project accordingly.

builtbyproxy commented 4 years ago

I don't understand why you're sending me to the PR we are currently in?

That said the files changed are all internal. My issue installing it was because we were also had pod 'Intercom' in our podfile causing a clash. I believe this was needed at some point but I can't say for sure

ZeerakHameem32 commented 4 years ago

Guys, i am on 5.5.1. I can't receive deep link in iOS push notification. I think that might be related to Intercom iOS sdk not being 6.x.x. I just have to unlink react-native-intercom. Install intercom from this PR and link again?

slorber commented 4 years ago

Hey, wanted to link the deprecation notice: https://www.intercom.com/changes/en/what-the-upcoming-intercom-mobile-sdk-v-deprecation-means-for-you-

image

slorber commented 4 years ago

BTW I'm also unable to receive pushes on Android. To me it looks like something is broken on Intercom side because I really double checked everything in my newly updated app using RN-intercom 13.0/intercom 6.0. Also, it used to work in production and apparently it does not anymore.

I've described the problem more in details here: https://github.com/tinycreative/react-native-intercom/issues/307#issuecomment-582045154

jste7102 commented 4 years ago

Just echoing @builtbyproxy, do you know when we can expect a new version with the intercom update?

builtbyproxy commented 4 years ago

@jste7102 Work with me on this, I have it working internally. The newest version is live here

I run version 14.0.0 without issues. If you are getting issues can you please create an issue and request me on it. We can pursue it there in order to not clutter this thread

jste7102 commented 4 years ago

@builtbyproxy everythings good, I was checking releases here https://github.com/tinycreative/react-native-intercom/releases and didn't realize that the npm package had actually been updated. Running 14.0.0 now and everything seems fine. Thanks!