search

tinycreative / react-native-intercom

React Native wrapper for Intercom.io
MIT License
405 stars 279 forks source link

Register both user id and email on Android's registerIdentifiedUser #343

Closed lucasfronza closed 4 years ago

lucasfronza commented 4 years ago

This matches current iOS implementation of registerIdentifiedUser on IntercomWrapper.m.

rolfb commented 4 years ago

Merge and release?

rolfb commented 4 years ago

Verified that this fixes the issue with multiple Intercom users having the same email. 

{
  "code": "conflict",
  "message": "Multiple existing users match this email address <email> - must be more specific using user_id"
}
ilyagru commented 4 years ago

Hey guys, is it something that could be merged very soon? I'm facing the same issue that is blocking our release.

rolfb commented 4 years ago

@browniefed it seems like you can merge this? pretty please with sugar on top? 🍨

rolfb commented 4 years ago

@asamiller do you feel inclined to merge this? mentioning you as you are the other official member of tinycreative org.

browniefed commented 4 years ago

released in v14.1

rolfb commented 4 years ago

Thank you @browniefed, much appreciated 😃