search

tinyduypham / coderrestaurant

Week 1 Assignment - CoderRestaurant
0 stars 0 forks source link

Submitting Assignment 1 for CoderSchool #1

Open PhuongXmaster opened 8 years ago

PhuongXmaster commented 8 years ago

Contributors: Duy Pham + Phuong Doan We didn't have time to retouch and go through all optional tasks. Thank you for your review.

/cc @coderschoolreview

coderschoolreview commented 8 years ago

Thank you for your Ruby submission, duyphamattinypulsecom!

:x: Unfortunately there are some problems with your submission:

tinyduypham commented 8 years ago

@coderschoolreview

we have forgotten to deploy to heroku :(

https://coderrestaurant.herokuapp.com has been added to README.md

Thanks

chug2k commented 8 years ago

Thanks for your submission. Please remember that in the future, each student should submit an individual homework assignment.

Good job on the assignment. I like how you implemented the "sort" feature by making the header clickable. The way you implemented get_foods in FoodsController is good. It would be nicer to use the before_action on line 2. Right now you have:

before_action :set_food, only: [:show, :edit, :update, :destroy]

You could add one more line:

before_action :get_foods, only: [:show, :index]

and then you don't have to call @foods = get_foods individually. Remember - DRY: Don't Repeat Yourself. :sweat_smile: You could do the same for set_category.

You did not fulfill one of the requirements:

Good job implementing the reviews and comments.

I am looking forward to your submissions next week!

PhuongXmaster commented 8 years ago

Hi Charles,

I thought we do the assignment in group. Do we work in group but submit individually or work individually as well?

Regards, Phuong.

On Sat, Dec 12, 2015 at 1:23 PM, Charles Lee notifications@github.com wrote:

Thanks for your submission. Please remember that in the future, each student should submit an individual homework assignment.

Good job on the assignment. I like how you implemented the "sort" feature by making the header clickable. The way you implemented get_foods in FoodsController is good. It would be nicer to use the before_action on line 2. Right now you have:

before_action :set_food, only: [:show, :edit, :update, :destroy]

You could add one more line:

before_action :get_foods, only: [:show, :index]

and then you don't have to call @foods = get_foods individually. Remember

  • DRY: Don't Repeat Yourself. [image: :sweat_smile:] You could do the same for set_category.

You did not fulfill one of the requirements:

  • The User is taken to a "Thank you for your order page" that lists the name of item, the total cost (delivery should cost 20,000 VND), the user's name, the user's address, and the time the order was created in human-readable format (for example, Tuesday, December 1, 15:25).

Good job implementing the reviews and comments.

I am looking forward to your submissions next week!

— Reply to this email directly or view it on GitHub https://github.com/duyphamattinypulsecom/coderrestaurant/issues/1#issuecomment-164114633 .