assignment 2 - incognitochat

[tinyduypham]

@coderschoolreview

this is my assignment for week 2, thank for your reviews.

[coderschoolreview]

Thank you for your Ruby submission, duyphamattinypulsecom!

:star: Everything looks good with the format of your submission. We'll be providing a detailed review soon!

[chug2k]

Good work, and sorry for the slow review! This homework is on authentication, using ActiveRecord::Relation, dealing with model associations, using partials, and the items under Bonus help with upcoming topics we will cover.

I like your minimal style. ;) Good job with getting the requirements of the app correct.

Suggestions

• It's messy to be using session[:user_id] all over the place. Use your current_user helper instead when you can. For example, in messages_controller.rb, instead of:

if !m.read && m.receiver_id == session[:user_id]

you can do

if !m.read && m.receiver == current_user

Also along those lines you can compare objects instead of ids. For example,

relation.to.id == current_user.id

can become

relation.to == current_user

It's just a tiny bit cleaner.

• Good job filtering out the users in users/index. Good to think of that!
• Nice job with the relationships model. This is a pretty standard model, good job on figuring it out!