search

tinyerp / erppeek

A versatile tool for Odoo / OpenERP. *** Forked as Odooly ⟶
https://github.com/tinyerp/odooly
Other
171 stars 99 forks source link

Fixed unicode value #90

Closed danikmil closed 5 years ago

jf--- commented 6 years ago

see TravisCI build; not python3 compatible

eberloso commented 6 years ago

It is solved with https://github.com/tinyerp/erppeek/pull/101

In python2 the basestring is the parent of unicode, so we don't need to check unicode if basestring is checked.

In python3 everything 'is' str so we don't have to check it.

If you are having problems with it is probably you have the same problem than in https://github.com/tinyerp/erppeek/pull/101 , the basestring is set as basestring = str because the check of PY2 is wrong.

florentx commented 5 years ago

superseded by #101