search

tinygo-org / drivers

TinyGo drivers for sensors, displays, wireless adaptors, and other devices that use I2C, SPI, GPIO, ADC, and UART interfaces.
https://tinygo.org
BSD 3-Clause "New" or "Revised" License
599 stars 188 forks source link

makeybutton: better algorithm implementation #458

Closed deadprogram closed 1 year ago

deadprogram commented 1 year ago

This PR modifies the algorithm to better match the original.

ysoldak commented 1 year ago

How do you know it matches original better, trial and error or there is code available to compare with?

deadprogram commented 1 year ago

See https://github.com/sparkfun/MaKeyMaKey/blob/master/firmware/Arduino/makey_makey/makey_makey.ino for the "original".

I will add that link to the source for clarity.

ysoldak commented 1 year ago

And not approve, but LGTM :D