search

tinygo-org / drivers

TinyGo drivers for sensors, displays, wireless adaptors, and other devices that use I2C, SPI, GPIO, ADC, and UART interfaces.
https://tinygo.org
BSD 3-Clause "New" or "Revised" License
599 stars 188 forks source link

lsm303agr: fix I2C address auto increment for multi data read #478

Closed breml closed 1 year ago

breml commented 1 year ago

fixes: #475

breml commented 1 year ago

CC: @ysoldak, @alankrantas

breml commented 1 year ago

I confirm, that my test application, which uses the accelerometer works on both, micro:bit v1.5 and V2.2. I didn't test the other two sensors though, because I don't have a meaningful test app available.

alankrantas commented 1 year ago

Can confirm that micro:bit v1.5 and v2.0 works (with the official example, which use all three sensors) after applying the patch.

breml commented 1 year ago

@deadprogram This PR has been tested successfully on microbit V1.5, V2.0 and V2.2 (see above). For the reasoning and the details also see #475.

I think, this PR is ready to be merged.

deadprogram commented 1 year ago

Thank you very much for the fix @breml and to @alankrantas for testing. Now merging.