tinygo-org / drivers

TinyGo drivers for sensors, displays, wireless adaptors, and other devices that use I2C, SPI, GPIO, ADC, and UART interfaces.
https://tinygo.org
BSD 3-Clause "New" or "Revised" License
587 stars 180 forks source link

ili9341: st7789: fix SetScrollArea #581

Closed aykevl closed 1 year ago

aykevl commented 1 year ago

The existing code was broken in a few ways:

I haven't fixed the st7735 implementation, because I didn't have example code on hand that would easily work on a st7735 screen. This is left as a TODO for the future.

Found while working on hardware scrolling support in https://github.com/aykevl/tinygl.

aykevl commented 1 year ago

I have a patch ready that will fix https://github.com/tinygo-org/drivers/issues/573 but it depends on this patch and a decision on #582.

conejoninja commented 1 year ago

It didn't break my code, but I don't have a screen of different size (320), I don't see any issue with the code itself, so ... merge?

deadprogram commented 1 year ago

Thanks for the corrections @aykevl and to @conejoninja for review/test. Now merging.