search

tinygo-org / drivers

TinyGo drivers for sensors, displays, wireless adaptors, and other devices that use I2C, SPI, GPIO, ADC, and UART interfaces.
https://tinygo.org
BSD 3-Clause "New" or "Revised" License
585 stars 180 forks source link

Contributing #593

Closed Sanidhyafeaturist closed 10 months ago

Sanidhyafeaturist commented 10 months ago

Hello I am Sanidhyafeaturist and made changes to your repo I noticed that you made this for esp 8266 so I think I can help you.

conejoninja commented 10 months ago

Hello @Sanidhyafeaturist ,

Thanks for contributing to TinyGo/Drivers.

Please, read the CONTRIBUTING.md file if you didn't do it before: https://github.com/tinygo-org/drivers/blob/release/CONTRIBUTING.md

The PR should have been made to dev branch instead of release. Also, what is the purpose of the uploaded files? And the image? Which driver are you trying to contribute to? I don't think uploading them to the root folder is the correct place, but I'm not sure what is the purpose of the uploaded files, we need some sort of description of the changes and purpose. Also, is preferable to upload the source code instead of a binary blob/hex from unknown origin.

I'm closing this PR until more information is provided.

Regards