search

tinygo-org / drivers

TinyGo drivers for sensors, displays, wireless adaptors, and other devices that use I2C, SPI, GPIO, ADC, and UART interfaces.
https://tinygo.org
BSD 3-Clause "New" or "Revised" License
585 stars 180 forks source link

pcf8523: RTC driver #599

Closed trichner closed 9 months ago

trichner commented 9 months ago

Driver for the pcf8523 RTC clocks as found on https://www.adafruit.com/product/2922 .

Interface similar to other RTC drivers :)

trichner commented 9 months ago

Test's fail because I use some go1.18 features, e.g. pcf8523/pcf8523_test.go:30:2: implicit function instantiation requires go1.18 or later (-lang was set to go1.15; check go.mod)

Is it intentionally still at go1.15 or is that just not updated?

deadprogram commented 9 months ago

Should probably update the minimum version.

trichner commented 9 months ago

Should probably update the minimum version.

Bumped to 1.18, works all fine now.

deadprogram commented 9 months ago

@trichner I pulled your commits into #600 where I rebased them together and merged into dev. Thank you very much for all your work on this! Now closing this PR.

trichner commented 9 months ago

@trichner I pulled your commits into #600 where I rebased them together and merged into dev. Thank you very much for all your work on this! Now closing this PR.

Wonderful, thanks for the reviews and help!