tinygo-org / drivers

TinyGo drivers for sensors, displays, wireless adaptors, and other devices that use I2C, SPI, GPIO, ADC, and UART interfaces.
https://tinygo.org
BSD 3-Clause "New" or "Revised" License
585 stars 180 forks source link

lora/lorawan: Further refactoring #611

Closed deadprogram closed 8 months ago

deadprogram commented 8 months ago

This PR is to perform further refactoring after #603 has been merged.

deadprogram commented 8 months ago

Any further feedback on this @iamemilio @mirackara @soypat or anyone else?

iamemilio commented 8 months ago

Minor Nit pick, but overall LGTM. Much less code duplication

deadprogram commented 8 months ago

Now merging, thanks for the work on #603 @iamemilio and @mirackara