move netdev interface to use net/netip for IP addr/ports

tinygo-org / drivers

TinyGo drivers for sensors, displays, wireless adaptors, and other devices that use I2C, SPI, GPIO, ADC, and UART interfaces.

https://tinygo.org

BSD 3-Clause "New" or "Revised" License

607 stars 192 forks source link

move netdev interface to use net/netip for IP addr/ports #622

Closed scottfeldman closed 10 months ago

scottfeldman commented 10 months ago

Matches changes to netdever interface made in tinygo-org/net#8. These two PRs are paired. If one goes, both go.

deadprogram commented 10 months ago

Now merging, thanks for working on this @scottfeldman and for review @soypat

soypat commented 10 months ago

Was looking at the code again and just thought to myself this was a really good move! Lots of heap allocations seem to be gone now! Thanks @scottfeldman for the contribution!

scottfeldman commented 10 months ago

Yes, it was worth it. What next @soypat?

soypat commented 10 months ago

@scottfeldman Now we use the API! As for the netdev-3 PR I'm still working on the TCP implementation. it's coming along nicely but its got a while to go before being lwip!