tinygo-org / drivers

TinyGo drivers for sensors, displays, wireless adaptors, and other devices that use I2C, SPI, GPIO, ADC, and UART interfaces.
https://tinygo.org
BSD 3-Clause "New" or "Revised" License
584 stars 180 forks source link

ssd1306: Displayer interface improvements #665

Closed deadprogram closed 2 months ago

deadprogram commented 4 months ago

This PR is to implement the pixel package based interface for the SSD1306 display.

aykevl commented 4 months ago

Does this display support any other pixel formats than the one monochrome pixel format? If not, I would suggest not using generics and simply using DrawBitmap(x, y int16, bitmap pixel.Image[pixel.MonochromeVertical]) error. This will still match the generic interface in TinyGL. (If needed, it's relatively simple to change the ssd1306 driver to be generic in the future without breaking backwards compatibility).

deadprogram commented 2 months ago

Closing since #663 and #671 are doing this better.