search

tinylib / msgp

A Go code generator for MessagePack / msgpack.org[Go]
MIT License
1.77k stars 189 forks source link

Add Go v1.22.x to CI workflow #351

Closed VirrageS closed 4 days ago

VirrageS commented 5 days ago

This adds 1.22.x Go version to CI workflow so we also test against this version to make sure everything works fine.

klauspost commented 5 days ago

I think it is ok to remove 1.18 support. It is far beyond EOL.

VirrageS commented 5 days ago

@klauspost It is your call, I can keep 1.18 for now.

klauspost commented 5 days ago

Remove it in the PR. Having 4 versions back should be more than enough. Giving @philhofer a bit of time to object :)

VirrageS commented 5 days ago

From what I see the https://github.com/philhofer/fwd/commit/fbbf4953d98612dac320a9051da34e3e761d1df7 requires at least 1.20. And based on the output of Go 1.22 test, it seems to require that we use this new unsafe.Slice. So I think we would need to drop 1.19 too :(

klauspost commented 5 days ago

I'm not going to object to that. Personally I support last 3 versions, which is already one more than Go, but I don't know if Phil has an opinion on this.

I suggest you add that to this PR, we can adjust if needed.

philhofer commented 4 days ago

Dropping support for EOL'd go versions is fine to me. LGTM.