search

tinylibs / tinybench

🔎 A simple, tiny and lightweight benchmarking library!
MIT License
1.73k stars 36 forks source link

skip empty event #55

Closed sirenkovladd closed 11 months ago

sirenkovladd commented 1 year ago

Fixes: https://github.com/tinylibs/tinybench/issues/54

sirenkovladd commented 1 year ago

@Uzlopak @kibertoad @Aslemammad

Uzlopak commented 1 year ago

The question, which has to be discussed before hand is, if it makes sense to ignore the non existing task, or to throw a custom error.

sirenkovladd commented 1 year ago

I don't have much respect for throwing errors I suggest returning boolean instead of this

Uzlopak commented 1 year ago

with returning this we allow chaining/ train wreck pattern.

sirenkovladd commented 1 year ago

are you sure adding remove to the chain is a good idea?