tinymce / generator-tinymce

Yeoman generator for TinyMCE plugins
Other
6 stars 5 forks source link

no dev host/port provided #1

Open thedannywahl opened 5 years ago

thedannywahl commented 5 years ago

It seems like after the migration from webpack-dev-server to grunt webpack in 5585ad8734eba94701a5bbc4dd74255e55f97ba5 that there's no dev server option anymore.

Previously npm start or nodemon start would start webpack-dev-server on localhost:8080. Now using npm start gives the following:

npm start -dd
npm info it worked if it ends with ok
npm verb cli [ '/usr/local/Cellar/node/11.10.0/bin/node',
npm verb cli   '/usr/local/bin/npm',
npm verb cli   'start',
npm verb cli   '-dd' ]
npm info using npm@6.7.0
npm info using node@v11.10.0
npm verb run-script [ 'prestart', 'start', 'poststart' ]
npm info lifecycle sentimony-2@1.0.0~prestart: sentimony-2@1.0.0
npm info lifecycle sentimony-2@1.0.0~start: sentimony-2@1.0.0

> sentimony-2@1.0.0 start /Users/dwahl/Scripts/sentimony2/sentimony-2
> grunt -v webpack --verbose

Initializing
Command-line options: --verbose

Reading "Gruntfile.js" Gruntfile...OK

Registering Gruntfile tasks.
Reading package.json...OK
Parsing package.json...OK
Initializing config...OK

Registering "grunt-contrib-clean" local Npm module tasks.
Reading /Users/dwahl/Scripts/sentimony2/sentimony-2/node_modules/grunt-contrib-clean/package.json...OK
Parsing /Users/dwahl/Scripts/sentimony2/sentimony-2/node_modules/grunt-contrib-clean/package.json...OK
Loading "clean.js" tasks...OK
+ clean

Registering "grunt-contrib-concat" local Npm module tasks.
Reading /Users/dwahl/Scripts/sentimony2/sentimony-2/node_modules/grunt-contrib-concat/package.json...OK
Parsing /Users/dwahl/Scripts/sentimony2/sentimony-2/node_modules/grunt-contrib-concat/package.json...OK
Loading "concat.js" tasks...OK
+ concat

Registering "grunt-contrib-copy" local Npm module tasks.
Reading /Users/dwahl/Scripts/sentimony2/sentimony-2/node_modules/grunt-contrib-copy/package.json...OK
Parsing /Users/dwahl/Scripts/sentimony2/sentimony-2/node_modules/grunt-contrib-copy/package.json...OK
Loading "copy.js" tasks...OK
+ copy

Registering "grunt-contrib-uglify" local Npm module tasks.
Reading /Users/dwahl/Scripts/sentimony2/sentimony-2/node_modules/grunt-contrib-uglify/package.json...OK
Parsing /Users/dwahl/Scripts/sentimony2/sentimony-2/node_modules/grunt-contrib-uglify/package.json...OK
Loading "uglify.js" tasks...OK
+ uglify

Registering "grunt-shell" local Npm module tasks.
Reading /Users/dwahl/Scripts/sentimony2/sentimony-2/node_modules/grunt-shell/package.json...OK
Parsing /Users/dwahl/Scripts/sentimony2/sentimony-2/node_modules/grunt-shell/package.json...OK
Loading "shell.js" tasks...OK
+ shell

Registering "grunt-tslint" local Npm module tasks.
Reading /Users/dwahl/Scripts/sentimony2/sentimony-2/node_modules/grunt-tslint/package.json...OK
Parsing /Users/dwahl/Scripts/sentimony2/sentimony-2/node_modules/grunt-tslint/package.json...OK
Loading "tslint.js" tasks...OK
+ tslint

Registering "grunt-webpack" local Npm module tasks.
Reading /Users/dwahl/Scripts/sentimony2/sentimony-2/node_modules/grunt-webpack/package.json...OK
Parsing /Users/dwahl/Scripts/sentimony2/sentimony-2/node_modules/grunt-webpack/package.json...OK
Loading "webpack-dev-server.js" tasks...OK
+ webpack-dev-server
Loading "webpack.js" tasks...OK
+ webpack

Registering "@ephox/swag" local Npm module tasks.
Reading /Users/dwahl/Scripts/sentimony2/sentimony-2/node_modules/@ephox/swag/package.json...OK
Parsing /Users/dwahl/Scripts/sentimony2/sentimony-2/node_modules/@ephox/swag/package.json...OK
Loading "rollup.js" tasks...OK
+ rollup
Loading "Gruntfile.js" tasks...OK
+ default, version

Running tasks: webpack

Running "webpack" task
Live Reload listening on port 35729

Hash: 6abe0dfa33e3ae8153ae                                                    c Version: webpack 4.29.5 / grunt-webpack 3.1.3
Time: 395ms
Built at: 02/22/2019 7:02:38 AM
      Asset      Size  Chunks             Chunk Names
    demo.js  4.96 KiB    main  [emitted]  main
demo.js.map   4.7 KiB    main  [emitted]  main
Entrypoint main = demo.js demo.js.map
[./src/demo/ts/Demo.ts] 166 bytes {main} [built]
[./src/main/ts/Plugin.ts] 427 bytes {main} [built]

(I modified the package.json to enable verbose output)

It's clearly running as modifying any of the plugin files triggers the Live Reload. Should webpack-dev-server be added as a start option in the gruntfile?

jdus commented 5 years ago

Just wanted to use yeoman for creating new plugins and ran into the same issue. For new developers it must be confusing, since the website suggests using yeoman.

mikejw commented 2 years ago

bump.