search

tinymce / generator-tinymce

Yeoman generator for TinyMCE plugins
Other
6 stars 5 forks source link

Missing dom lib in tsconfig file #11

Closed thiberaw closed 3 years ago

thiberaw commented 3 years ago

Just after bootstraping the generator, many errors on yarn run build or yarn run test-manual because dom is not included as lib in tsconfig.

I am pasting just a few

ERROR in /home/thibaut/Concord/concordfields/node_modules/tinymce/tinymce.d.ts(2844,23):TS2304: Cannot find name 'Storage'.

ERROR in /home/thibaut/Concord/concordfields/node_modules/tinymce/tinymce.d.ts(2852,66):TS2304: Cannot find name 'Node'.

ERROR in /home/thibaut/Concord/concordfields/node_modules/tinymce/tinymce.d.ts(2859,45):TS2304: Cannot find name 'Window'.

ERROR in /home/thibaut/Concord/concordfields/node_modules/tinymce/tinymce.d.ts(2860,54):TS2304: Cannot find name 'Document'.

ERROR in /home/thibaut/Concord/concordfields/node_modules/tinymce/tinymce.d.ts(2860,65):TS2304: Cannot find name 'ShadowRoot'.

I wanted to create a pull request but I am not allowed to push a branch on the remote.

lnewson commented 3 years ago

Thanks for the report! This issue was fixed in v1.4 which was released in February.