tinymce / tinymce-angular

Official TinyMCE Angular Component
MIT License
328 stars 92 forks source link

Angular 12 support #262

Closed JamieVangeysel closed 2 years ago

JamieVangeysel commented 3 years ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Migration failed: Incompatible peer dependencies found.

Describe the solution you'd like A clear and concise description of what you want to happen. upgrade deps to support angular 12, with angular 13 coming in October/November having it support 12 would be great

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered. Remaining on angular 11

exalate-issue-sync[bot] commented 3 years ago

Ref: INT-2633

jscasca commented 3 years ago

Hi @Jamie-Vangeysel

What version of the tinymce-angular are you using? Currently, version ^4.2 peer dependencies requirements are >=9.0.0 so that should work for Angular 12. You might have an older package with a cap on peerDependencies

jscasca commented 2 years ago

Closing due to inactivity

JamieVangeysel commented 2 years ago

❯ ng update The installed local Angular CLI version is older than the latest stable version. Installing a temporary version to perform the update. Installing packages for tooling via npm. Installed packages for tooling via npm. Using package manager: 'npm' Collecting installed dependencies... Found 33 dependencies. We analyzed your package.json, there are some packages to update:

  Name                               Version                  Command to update
 --------------------------------------------------------------------------------
  @angular/cli                       11.2.2 -> 12.2.10        ng update @angular/cli
  @angular/core                      11.2.3 -> 12.2.10        ng update @angular/core

There might be additional packages which don't provide 'ng update' capabilities that are outdated.
You can update the additional packages by running the update command of your package manager.

❯ ng update @angular/core @angular/cli The installed local Angular CLI version is older than the latest stable version. Installing a temporary version to perform the update. Installing packages for tooling via npm. Installed packages for tooling via npm. Using package manager: 'npm' Collecting installed dependencies... Found 33 dependencies. Fetching dependency metadata from registry... Package "@tinymce/tinymce-angular" has an incompatible peer dependency to "@angular/common" (requires ">=9.0.0 <11.0.0" (extended), would install "12.2.10"). Package "@tinymce/tinymce-angular" has an incompatible peer dependency to "@angular/core" (requires ">=9.0.0 <11.0.0" (extended), would install "12.2.10"). Package "@tinymce/tinymce-angular" has an incompatible peer dependency to "@angular/forms" (requires ">=9.0.0 <11.0.0" (extended), would install "12.2.10"). ✖ Migration failed: Incompatible peer dependencies found. Peer dependency warnings when installing dependencies means that those dependencies might not work correctly together.

jscasca commented 2 years ago

@Jamie-Vangeysel Looks like an older version. You will have to update the @tinymce/tinymce-angular before updating the angular packages.

You can just run yarn upgrade-interactive --latest and select @tinymce/tinymce-angular and update to v4.2.4, or remove the package from node_modules and reinstall so you get the latest. After updating the tinymce-angular package you should be able to run the ng update command without issues

JamieVangeysel commented 2 years ago

seems like my deps file was wrong 🤦🏼‍♂️ "@tinymce/tinymce-angular": "4.2.0" instead of "@tinymce/tinymce-angular": "^4.2.0" now npm update installed the correct version of TinyMCE and ng update works, thanks!

jscasca commented 2 years ago

Glad it's working now!