search

tinymce / tinymce-angular

Official TinyMCE Angular Component
MIT License
320 stars 93 forks source link

perf: remove event listeners when the component gets destroyed and reduce change detection cycles #271

Closed arturovt closed 2 years ago

jscasca commented 2 years ago

@arturovt thanks for this PR. Did you get the CLA email by any chance? we can't merge these changes until you sign the CLA

arturovt commented 2 years ago

Hey @jscasca . I've seen that it requires CLA to be signed, but I didn't get any email :( Are you able to send it to the email mentioned in my profile?

jscasca commented 2 years ago

@arturovt I tried triggering a re-delivery and since the commit points to that same email I hoping you get the CLA email but if you don't let me know and I'll try to chase it from my side

arturovt commented 2 years ago

@jscasca I didn't get an email, unfortunately. Also checked the spam folder and it's empty.

EkimChau commented 2 years ago

Hi arturovt, we are currently having issues with our CLA system, once its back up you should get an email. Thank you for your contribution

Afraithe commented 2 years ago

I have manually triggered the email send for you, can you check gmail again, and spam folder?

arturovt commented 2 years ago

Yeah, I got the email.