search

tinymce / tinymce-angular

Official TinyMCE Angular Component
MIT License
320 stars 92 forks source link

DEVOPS-35: Containerised build #305

Closed tjdett closed 1 year ago

tjdett commented 1 year ago

Runs the build from a Node 18 container running in a K8S cluster.

jscasca commented 1 year ago

I think it would be nice to have a simpler way to specify the pod template. Otherwise it looks good

tjdett commented 1 year ago

I think it would be nice to have a simpler way to specify the pod template.

@jscasca There is one of those actually: https://plugins.jenkins.io/kubernetes/#plugin-content-configuration-reference

Unfortunately it's lacking something that's fairly critical to scheduling build resources on-demand. Resource requests/limits: https://plugins.jenkins.io/kubernetes/#plugin-content-modify-cpus-and-memory-requestlimits-kubernetes-resource-api

There's actually a lot of boilerplate that's not in that YAML config, because the plugin merges its default config that contains the jnlp container. Fortunately it's just vanilla Kubernetes pod configuration otherwise, which means there are plenty of examples out there to follow when making modifications.