search

tinymce / tinymce-angular

Official TinyMCE Angular Component
MIT License
320 stars 92 forks source link

fix: cursor jumping at the beginning #371

Open davidediak opened 4 months ago

davidediak commented 4 months ago

https://github.com/tinymce/tinymce-angular/issues/321

davidediak commented 3 months ago

Sure, I fixed your tests and also added a test related to my fix. Please feel free to contribute to the tests if needed, I'm not really familiar with your internal testing lib.

danoaky-tiny commented 3 months ago

Ah thank you. #367 also has a fix for this failing test. Once that's merged I'll rereview

constanzaccg commented 1 month ago

Hi! Is there any plan to incorporate this fix soon? Thank you

danoaky-tiny commented 1 month ago

@davidediak This needs a merge from main. Just to do with the tests, won't need much change from you.

davidediak commented 1 month ago

@danoaky-tiny sure, done.

EkimChau commented 1 month ago

Hello davidediak,

Thank you for your code contribution, in order for Tiny Inc to accept your code, we will need permission to use your code contribution, this can be done through the Tiny Contributor License Agreement (Tiny CLA). Please contact legal@tiny.cloud to sign the Tiny CLA agreement.

davidediak commented 1 month ago

@EkimChau you have my permission to use my code, given the fact that I spent time fixing the bug and did open a PR. I have no intention of proving your company with my personal data.

TheSpyder commented 1 month ago

This is clearly stated in the contributing guide. We don't have an automated system for it at the moment. https://github.com/tinymce/tinymce-angular/blob/5bcfde80e8c5cb78b806d14c5c9e11d1af2c3471/CONTRIBUTING.md?plain=1#L8

The CLA protects us, our open-source community and our customers from the distribution of unauthorised code. It's non-negotiable, sorry.