search

tinymce / tinymce-angular

Official TinyMCE Angular Component
MIT License
320 stars 92 forks source link

Error: export 'takeUntil' (imported as 'takeUntil') was not found in 'rxjs' in latest version 8.0.0 #388

Closed Mehadmushtaq closed 1 month ago

Mehadmushtaq commented 1 month ago

i installed the latest available version of @tinymce/tinymce-angular which is 8.0.0, after successful installation when i try to build my project it throws an unexpected error as you can see below:

image

when i just navigate to tinymce-tinymce-angular.mjs i found that takeUntil is imported directly from rxjs which was changed after rxjs v5 and now we have to import it from "rxjs/operators" instead of "rxjs" that i throwing error.

here is the image showing tinymce-tinymce-angular.mjs file: image

danoaky-tiny commented 1 month ago

RxJS has deprecated the 'rxjs/operators' import since v7.2.0 (3 years ago). Although I understand that Angular 17 still supports using RxJS ^6.5.3. So at the very least I think we should add RxJS v7.4.0 as a peer dependency to this package. Internal ref: INT-3306

Personally I'm much less inclined to put back support for deprecated RxJS imports, but if more people have this problem we'll consider a patch for it.

danoaky-tiny commented 1 month ago

Closing, as #389 is merged