search

tinymce / tinymce-blazor

Blazor integration
MIT License
45 stars 13 forks source link

Toolbar popup does not disappear when navigating away or editor has been disposed #43

Closed nguyenhthai closed 2 years ago

nguyenhthai commented 2 years ago

I ran into this issue recently and can replicate this with my repo here.

Issue: If toolbar is displayed and the editor either been disposed or we navigate away from the current component, the toolbar popup is still shown.

Reproducible step:

  1. Click on the "More" icon to toggle toolbar
  2. Either navigate to different page or click Destroy editor button to dispose the editor
  3. The toolbar popup is still displayed

Some screenshots to show the issue image image

exalate-issue-sync[bot] commented 2 years ago

Ref: INT-2846

jscasca commented 2 years ago

@nguyenhthai Thanks for bringing that up. It seems that the order it disposes of the editor is breaking the popup and leaving it there. I'll get that fixed

jscasca commented 2 years ago

This has been addressed in our latest release, v1.0.2.

Let me know if you still have issues with it

nguyenhthai commented 2 years ago

@jscasca Unfortunately, the fix for this reverted the fix for #15. I have updated my repo to show the issues.

jscasca commented 2 years ago

@nguyenhthai I might have to do a better clean up job for multiple editors. Can you open a new tickets for this? 'Editor clean up not properly disposing of event handlers' maybe?

nguyenhthai commented 2 years ago

do a better clean up job for multiple editors. Can you open a new tickets for this? 'Editor clean up not properly disposing of event handlers' maybe?

Sure will do