search

tinymce / tinymce-react

Offical TinyMCE React component
MIT License
937 stars 152 forks source link

Allow tabIndex to be passed into editor #508

Closed gjulivan closed 2 months ago

gjulivan commented 3 months ago

Currently, tabIndex can't be passed into the editor. and this is not good for accessibility.

as mentioned on tinymce documentation: https://www.tiny.cloud/docs/tinymce/latest/editor-important-options/#taborder tabIndex only able to be passed before init phase, Thus, we need to pass tabIndex on component render.

This PR allows tabIndex to be passed as props on tinymce-react

EkimChau commented 2 months ago

gjulivan

Hello gjulivan,

Thank you for your code contribution, in order for Tiny Inc to accept your code, we will need permission to use your code contribution, this can be done through the Tiny Contributor License Agreement (Tiny CLA). Please contact legal@tiny.cloud to sign the Tiny CLA agreement.

gjulivan commented 2 months ago

gjulivan

Hello gjulivan,

Thank you for your code contribution, in order for Tiny Inc to accept your code, we will need permission to use your code contribution, this can be done through the Tiny Contributor License Agreement (Tiny CLA). Please contact legal@tiny.cloud to sign the Tiny CLA agreement.

on it. thank you.

EkimChau commented 2 months ago

gjulivan

Hello gjulivan, Thank you for your code contribution, in order for Tiny Inc to accept your code, we will need permission to use your code contribution, this can be done through the Tiny Contributor License Agreement (Tiny CLA). Please contact legal@tiny.cloud to sign the Tiny CLA agreement.

on it. thank you.

Thank you gjulivan, Tiny has received the signed CLA and we will accept your code contribution.