search

tinymighty / wiki-seo

A simple MediaWiki extension to give you control over the html title and meta tags via a tag or parser function.
Other
17 stars 15 forks source link

Composer installs into WikiSeo instead of WikiSEO / improve README #15

Closed kghbln closed 9 years ago

kghbln commented 9 years ago

I just realised that composer installs into the WikiSeo directory which makes it different from the file release. I am not sure if this is ok.

andru commented 9 years ago

Yeah we should probably recommend that people actually copy the repo into a directory called WikiSeo since that follows the MediaWiki standard for extension directories. Or maybe WikiSEO but I'm not sure how to convince the MediaWiki Composer libraries to do that for us.

Either way, the extension is autoloaded by Composer - you don't need to put a require in LocalSettings - so it seems to me like something the user shouldn't be worrying about?

kghbln commented 9 years ago

Indeed, since Composer does install and autoload the extension the path does not really matter after all. One just has to be careful when switching to Composer that the former manual invocation gets removed. Ended up with two WikiSEOs yesterday. Probably the README should mention to remove both code and invocation line prior to installing with Composer.

andru commented 9 years ago

Ah, well spotted. I’ve not upgraded an existing installation yet so missed that.

If you want to update the readme I’ll merge it in, otherwise I’ll get to it in the coming days the next time I have the chance.=

kghbln commented 9 years ago

I should have know better since I have used Composer for other extensions. I was just wondering why I got two WikiSEOs instead of the expected error message complaining about the extra invocation. Will do a pull request.