an extra coma leads to error

tinymighty / wiki-seo

A simple MediaWiki extension to give you control over the html title and meta tags via a tag or parser function.

Other

17 stars 15 forks source link

an extra coma leads to error #29

Open giby opened 5 years ago

giby commented 5 years ago

Hi,

I used your addon; but I had an issue:

There is a coma that lead to a bug.

Best regards

Designburo commented 5 years ago

This is indeed incorrect. It will create an invalid JSON and will not be useable. for a quick fix add $jsonLD = rtrim( $jsonLD, ',' ); just before $jsonLD = $jsonLD.'}</script>'; in WikiSEO.body.php

octfx commented 5 years ago

This should be fixed in https://github.com/octfx/wiki-seo
Do mind, that this is still a work in progress though.