tinyos / tinyos-main

Main development repository for TinyOS (an OS for embedded, wireless devices).
1.41k stars 518 forks source link

Dead code in tools/bsl? #305

Open andrasbiro opened 10 years ago

andrasbiro commented 10 years ago

While tested some buildscripts, I think I found some dead code in the bsl directory. However, since I rarely use any msp430 stuff, I don't want to remove them without asking:

bradjc commented 10 years ago
  1. POPT_CPPBSL is set in the configure script if you have the popt library on your system already. If you do, then cppbsl will get built. Because I moved this to the tools I didn't want to add a dependency for something I don't expect most people to use. That being said, does anyone still use this? I have no idea. I use tinyos for the msp430 and don't use it.
  2. I do use pybsl/tos-bsl. After looking around, it appears the tools/platforms/msp430/pybsl/serial folder is an old copy of py-serial. Given that the serial folder gets installed to some weird directory (that configuration predates #190), I don't actually use it because import serial just pulls from the real py-serial library on my machine. I imagine we could get rid of the serial folder and just make py-serial a dependency.
andrasbiro commented 10 years ago
  1. You're right, in fact, I do have cppbsl installed on my system. But the tinyos make uses tos-bsl, so I still think it should be removed (it also means that some tinyos-tools package depend on popt, depending on the build system...)
  2. Probably tha same happend on my machine. I agree, we should add py-serial to the dependencies. As far as I remember, the python sdk needs that as well.