Expo not marked as optional peer - Githubissues

tinyplex / tinybase

The reactive data store for local‑first apps.

https://tinybase.org

MIT License

3.91k stars 89 forks source link

Expo not marked as optional peer #159

Closed abhishiv closed 4 months ago

abhishiv commented 4 months ago

Describe the bug

Hello, @tinyplex

Thank you very much for a great package.

Just FYI tinybase seems to pull in around 700 dependencies including stuff like expo

➜  pkg git:(refactor) ✗ npm uninstall tinybase -w xxx              

removed 714 packages, and audited 523 packages in 2s

Your Example Website or App

No response

Steps to Reproduce the Bug or Issue

No response

Expected behavior

No response

Screenshots or Videos

No response

Platform

OS: [e.g. macOS, Windows, Linux]
Browser: [e.g. Chrome, Safari, Firefox]
Version: [e.g. 91.1]

Additional context

No response

jamesgpearce commented 4 months ago

Everything* is an optional peer, or developer, dependency.

(* BUT I did notice that for some reason expo (a peer dependency) is not marked optional... so let me fix that!)

jamesgpearce commented 4 months ago

Yep, that fixed it! Please update to v5.0.4, delete your package-lock.json, and node_modules directory. Install again and you should have no dependencies brought in by TinyBase!

jamesgpearce commented 4 months ago

A bit embarrassing TBH. Thanks for finding! 🥰