tinyplex / tinybase

The reactive data store for local‑first apps.
https://tinybase.org
MIT License
3.9k stars 89 forks source link

fix jest-puppeteer globals import #188

Closed mulekick closed 1 month ago

mulekick commented 1 month ago

Summary

This PR contains a fix to import the jest-puppeteer globals in test/e2e/common.ts and reenable types resolution.

types resolution fix

The fix is in branch my_branch.

How did you test this change?

The end to end test suite passes 100%.

end to end tests

⚠️ Warning ⚠️

I had to do a npm i and update package-lock.json since npm ci errored. I don't know if the new package-lock.json should be merged or discarded.

jamesgpearce commented 1 month ago

Oh wow what awesome service! I didn't think to check there would be a breaking change (given the minor rev) but this makes sense. So cool!!!

mulekick commented 1 month ago

You're welcome ! The follow-up is part of contributing as well 👍