Closed mulekick closed 1 month ago
This PR contains a fix to import the jest-puppeteer globals in test/e2e/common.ts and reenable types resolution.
jest-puppeteer
test/e2e/common.ts
The fix is in branch my_branch.
my_branch
The end to end test suite passes 100%.
I had to do a npm i and update package-lock.json since npm ci errored. I don't know if the new package-lock.json should be merged or discarded.
npm i
package-lock.json
npm ci
Oh wow what awesome service! I didn't think to check there would be a breaking change (given the minor rev) but this makes sense. So cool!!!
You're welcome ! The follow-up is part of contributing as well 👍
Summary
This PR contains a fix to import the
jest-puppeteer
globals intest/e2e/common.ts
and reenable types resolution.The fix is in branch
my_branch
.How did you test this change?
The end to end test suite passes 100%.
⚠️ Warning ⚠️
I had to do a
npm i
and updatepackage-lock.json
sincenpm ci
errored. I don't know if the newpackage-lock.json
should be merged or discarded.