search

tinyproxy / tinyproxy

tinyproxy - a light-weight HTTP/HTTPS proxy daemon for POSIX operating systems
GNU General Public License v2.0
4.67k stars 645 forks source link

autoconf passes warning flags to compiler that are not valid #536

Open brad0 opened 1 month ago

brad0 commented 1 month ago

Tinyproxy version

1.11.1

Issue

checking to see if compiler understands -fdiagnostics-show-option -Wall -Wextra -Wno-unused-parameter -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -Wfloat-equal -Wundef -Wformat=2 -Wlogical-op -Wmissing-include-dirs -Wformat-nonliteral -Wold-style-definition -Wpointer-arith -Waggregate-return -Winit-self -Wpacked --std=c89 -ansi -Wno-overlength-strings -Wno-long-long -Wno-overlength-strings -Wdeclaration-after-statement -Wredundant-decls -Wmissing-noreturn -Wshadow -Wendif-labels -Wcast-qual -Wcast-align -Wwrite-strings -Wp,-D_FORTIFY_SOURCE=2 -fno-common... yes

warning: unknown warning option '-Wlogical-op'; did you mean '-Wlong-long'? [-Wunknown-warning-option]

OpenBSD clang version 16.0.6 Target: amd64-unknown-openbsd7.5 Thread model: posix InstalledDir: /usr/bin

rofl0r commented 1 month ago

we can't know whether warning options work or don't if the compiler doesn't return an error for unknown options - which is the sane way to react, what gcc does, and what's the assumption behind the snippet doing this. either way, it seems getting an additional warning when clang users compile the code is no big deal. you can probably easily circumvent it by either not adding -Wunknown-warning-option to your CFLAGS or in case it's a default, by adding -Werror-unknown-warning-option or -Wno-unknown-warning-option to your CFLAGS.