tinyzimmer / go-gst

Gstreamer bindings and utilities for golang

GNU Lesser General Public License v2.1

130 stars 37 forks source link

gst: add wrapper for deinit function #15

Closed solganik closed 3 years ago

solganik commented 3 years ago

Adding wrapper for deinit function.

solganik commented 3 years ago

@tinyzimmer any idea why do i get the root@9728ad43effa:/workspace# go build examples/bins/main.go

github.com/tinyzimmer/go-gst/gst

cgo-gcc-prolog: In function '_cgo_d934d0bd99ce_Cfunc_gst_deinit': cgo-gcc-prolog:66:49: warning: unused variable '_cgo_a' [-Wunused-variable]

tinyzimmer commented 3 years ago

@tinyzimmer any idea why do i get the root@9728ad43effa:/workspace# go build examples/bins/main.go

github.com/tinyzimmer/go-gst/gst

cgo-gcc-prolog: In function '_cgo_d934d0bd99ce_Cfunc_gst_deinit': cgo-gcc-prolog:66:49: warning: unused variable '_cgo_a' [-Wunused-variable]

Not sure - can take a look later and see. What platform just out of curiosity? Does it happen on other examples too?

solganik commented 3 years ago

On linux, inside the build docker

tinyzimmer commented 3 years ago

This could be due to the -Wall here. Could you maybe try dropping that argument on this PR and see if it fixes the issue.

I found this on StackOverflow that led me down that path. I'm just surprised it didn't pop up sooner.

solganik commented 3 years ago

yeah i saw this as well .. i removed the "unused warning" in additional patch

tinyzimmer commented 3 years ago

LGTM