search

tinyzimmer / go-gst

Gstreamer bindings and utilities for golang
GNU Lesser General Public License v2.1
130 stars 37 forks source link

'Fix could not determine kind of name for C.free' in Windows 11 #22

Closed nassah221 closed 2 years ago

nassah221 commented 2 years ago

Context: I was trying out the gst-bindings for use in a project of mine but could not get my go program to compile. After making a single change as described below, I was able to compile and use the bindings without any problem

Issue: gst_type_find.go:69:9: could not determine kind of name for C.free

image

Environment : Windows 11, GStreamer 1.18 msvc

Fix:

image

Result:

image

P.S. This is my first ever contribution to a project. Please let me know if the changes are not appropriate or if more details are required 😀

tinyzimmer commented 2 years ago

I had thought we squashed this with #3 but I'll take a second look. Possibly we just missed one or it got added later. Thanks for the PR and I'll check it in a bit 😄

hassanhdc commented 2 years ago

I had thought we squashed this with #3 but I'll take a second look. Possibly we just missed one or it got added later. Thanks for the PR and I'll check it in a bit 😄

Did you get a chance to look at it?

tinyzimmer commented 2 years ago

Ha thanks for pinging, I completely forgot about this. Should be fine, will go ahead and merge.